Some minor typos in predefined GXRModeObj

Post Reply
Eke
Posts: 64
Joined: Sat Mar 01, 2008 11:01 am

Some minor typos in predefined GXRModeObj

Post by Eke » Tue May 27, 2008 10:56 am

I just found these while debugging an application:

in TVPal264Ds & TVPal264DsAa:
(VI_MAX_HEIGHT_PAL/2 - 528/2)/2, // viYOrigin
should be
(VI_MAX_HEIGHT_PAL - 528)/2, // viYOrigin
in TVEurgb60Hz240Ds & TVEurgb60Hz240DsAa
(VI_MAX_HEIGHT_EURGB60 - 480/2)/2, // viYOrigin
should be
(VI_MAX_HEIGHT_EURGB60 - 480)/2, // viYOrigin

the following has no impact since YOrigin is 0 in every case but:

in TVNtsc240Ds & TVNtsc240DsAa:
(VI_MAX_HEIGHT_NTSC/2 - 480/2)/2, // viYOrigin
should be
(VI_MAX_HEIGHT_NTSC - 480)/2, // viYOrigin
generally, viYOrigin should always be (VI_MAX_HEIGHT-viHeight)/2, even when using non-interlaced doublestrike modes, only XFB height is divided by two, not VI

btw, EURGB60_ modes are missing from video_types.h ;)

Post Reply

Who is online

Users browsing this forum: No registered users and 61 guests