-Wconversion and libnds/include/*

Post Reply
User avatar
PypeBros
Posts: 39
Joined: Thu Nov 25, 2010 12:00 pm
Location: In a galaxy far, far away
Contact:

-Wconversion and libnds/include/*

Post by PypeBros » Mon Dec 20, 2021 10:41 am

Hi. While I had -Wconversion turned on for some debug build, I noticed that many of the libnds header files do not like that flag very much, but it also seem that they wouldn't require that much effort to support it.

One key element to fix seems to be the definition of

Code: Select all

BIT(n)
so that it produces an unsigned value (as most registers are defined as volatile unsigned registers and will receive values built from BIT()).

Although my install of libnds is a bit dated (1.7.3-1), I noted that none of this seems to have been fixed in the latest github version.
1) do you have any interest in having headers of libnds allowing -Wconversion flag (I feel it helps a lot with finding some arithmetic error in general)
2) would you like me to try getting the full set of latest headers work with it and then submit a patch ?

Best regards and best wishes for passing year *<:-)
Attachments
Wconversion.patch.txt
(3.69 KiB) Downloaded 91 times
NDS is the neatest piece of hardware since the C=64! Thanks for making it programmable ^_^

Post Reply

Who is online

Users browsing this forum: No registered users and 5 guests