Page 1 of 1

libnds: Typo bug in version 1.3.1 in background.h

Posted: Thu Dec 25, 2008 10:16 am
by Antonz
include/nds/arm9/background.h:546 :

Code: Select all

void bgSet(int id, int angle, s32 sx, s32 sy, s32 scrollX, s32 scrollY, s32 rotCenterX, s32 rotCenterY)
{
   bgState[id].scaleX = sx;
	bgState[id].scaleY = sy;

   bgState[id].scrollX = scrollX;
	bgState[id].scrollY = scrollX; // <---- Here
   
  	bgState[id].centerX = rotCenterX;
	bgState[id].centerY = rotCenterY;

   bgSetRotate(id, angle);
}
I think it should be scrollY. Found because compiler warns about unused parameter with -Wall -Wextra flags.

Re: libnds: Typo bug in version 1.3.1 in background.h

Posted: Fri Dec 26, 2008 1:47 am
by WinterMute
Thanks for catching that, it's been corrected in SVN & will be part of the libnds 1.3.2 update.